Commit 7b2c7b62 authored Apr 10, 2019 by Thomas Gleixner

arm64/stacktrace: Remove the pointless ULONG_MAX marker



Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lkml.kernel.org/r/20190410103644.220247845@linutronix.de

parent fa983399

arch/arm64/kernel/stacktrace.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -140,8 +140,6 @@ void save_stack_trace_regs(struct pt_regs regs, struct stack_trace trace)
		#endif

		walk_stackframe(current, &frame, save_trace, &data);
		if (trace->nr_entries < trace->max_entries)
		trace->entries[trace->nr_entries++] = ULONG_MAX;
		}
		EXPORT_SYMBOL_GPL(save_stack_trace_regs);

		@@ -172,8 +170,6 @@ static noinline void __save_stack_trace(struct task_struct *tsk,
		#endif

		walk_stackframe(tsk, &frame, save_trace, &data);
		if (trace->nr_entries < trace->max_entries)
		trace->entries[trace->nr_entries++] = ULONG_MAX;

		put_task_stack(tsk);
		}

Admin message