Commit 7b1a1322 authored Mar 04, 2015 by Nan Li Committed by Rafael J. Wysocki Mar 10, 2015

ACPI / sysfs: Treat the count field of counter_show() as unsigned



The count field is an unsigned 32bit value, and the
counter_show() function should also treat it as a unsigned
value.

Otherwise the counter may show negative number as we found on a
machine:
...
gpe23:        0   invalid
gpe24: -2071733   enabled
gpe25:        0   invalid
...
gpe_all: -2070980
sci: -2070949

Signed-off-by: Nan Li <nli@suse.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 9eccca08

drivers/acpi/sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -527,7 +527,7 @@ static ssize_t counter_show(struct kobject *kobj,
		acpi_irq_not_handled;
		all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS + COUNT_GPE].count =
		acpi_gpe_count;
		size = sprintf(buf, "%8d", all_counters[index].count);
		size = sprintf(buf, "%8u", all_counters[index].count);

		/* "gpe_all" or "sci" */
		if (index >= num_gpes + ACPI_NUM_FIXED_EVENTS)

Admin message