Commit 7b11f69f authored by Kris Katterjohn's avatar Kris Katterjohn Committed by David S. Miller
Browse files

[NET]: Clean up comments for sk_chk_filter()



This removes redundant comments, and moves one comment to a better
location.

Signed-off-by: default avatarKris Katterjohn <kjak@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 46b86a2d
Loading
Loading
Loading
Loading
+3 −7
Original line number Diff line number Diff line
@@ -287,7 +287,9 @@ load_b:
 * no references or jumps that are out of range, no illegal
 * instructions, and must end with a RET instruction.
 *
 * Returns 0 if the rule set is legal or a negative errno code if not.
 * All jumps are forward as they are not signed.
 *
 * Returns 0 if the rule set is legal or -EINVAL if not.
 */
int sk_chk_filter(struct sock_filter *filter, int flen)
{
@@ -299,7 +301,6 @@ int sk_chk_filter(struct sock_filter *filter, int flen)

	/* check the filter code now */
	for (pc = 0; pc < flen; pc++) {
		/* all jumps are forward as they are not signed */
		ftest = &filter[pc];

		/* Only allow valid instructions */
@@ -383,11 +384,6 @@ int sk_chk_filter(struct sock_filter *filter, int flen)
		}
	}

	/*
	 * The program must end with a return. We don't care where they
	 * jumped within the script (its always forwards) but in the end
	 * they _will_ hit this.
	 */
        return (BPF_CLASS(filter[flen - 1].code) == BPF_RET) ? 0 : -EINVAL;
}