Commit 7b0ce727 authored Jul 22, 2015 by Robin Murphy Committed by Joerg Roedel Aug 03, 2015

of: iommu: Silence misleading warning



Printing "IOMMU is currently not supported for PCI" for
every PCI device probed on a DT-based system proves to be
both irritatingly noisy and confusing to users who have
misinterpreted it to mean they can no longer use VFIO device
assignment.

Since configuring DMA masks for PCI devices via
of_dma_configure() has not in fact changed anything with
regard to IOMMUs there really is nothing to warn about here;
shut it up.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 74d33293

drivers/iommu/of_iommu.c

+5 −3

Original line number	Original line	Diff line number	Diff line
	@@ -141,10 +141,12 @@ struct iommu_ops of_iommu_configure(struct device dev,
	struct iommu_ops *ops = NULL;		struct iommu_ops *ops = NULL;
	int idx = 0;		int idx = 0;

	if (dev_is_pci(dev)) {		/*
	dev_err(dev, "IOMMU is currently not supported for PCI\n");		* We can't do much for PCI devices without knowing how
			* device IDs are wired up from the PCI bus to the IOMMU.
			*/
			if (dev_is_pci(dev))
	return NULL;		return NULL;
	}

	/*		/*
	* We don't currently walk up the tree looking for a parent IOMMU.		* We don't currently walk up the tree looking for a parent IOMMU.

Admin message