Commit 7af43a76 authored Jan 22, 2020 by Chen Zhou Committed by Lee Jones Jan 23, 2020

backlight: qcom-wled: Fix unsigned comparison to zero



Fixes coccicheck warning:
./drivers/video/backlight/qcom-wled.c:1104:5-15:
	WARNING: Unsigned expression compared with zero: string_len > 0

The unsigned variable string_len is assigned a return value from the call
to of_property_count_elems_of_size(), which may return negative error code.

Fixes: 775d2ffb ("backlight: qcom-wled: Restructure the driver for WLED3")
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Kiran Gunda <kgunda@codeaurora.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent c8fdcc86

drivers/video/backlight/qcom-wled.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version)
		struct wled_config *cfg = &wled->cfg;
		struct device *dev = wled->dev;
		const __be32 *prop_addr;
		u32 size, val, c, string_len;
		int rc, i, j;
		u32 size, val, c;
		int rc, i, j, string_len;

		const struct wled_u32_opts *u32_opts = NULL;
		const struct wled_u32_opts wled3_opts[] = {

Admin message