Commit 7af03301 authored Jul 03, 2019 by Xin Long Committed by David S. Miller Jul 03, 2019

sctp: count data bundling sack chunk for outctrlchunks



Now all ctrl chunks are counted for asoc stats.octrlchunks and net
SCTP_MIB_OUTCTRLCHUNKS either after queuing up or bundling, other
than the chunk maked and bundled in sctp_packet_bundle_sack, which
caused 'outctrlchunks' not consistent with 'inctrlchunks' in peer.

This issue exists since very beginning, here to fix it by increasing
both net SCTP_MIB_OUTCTRLCHUNKS and asoc stats.octrlchunks when sack
chunk is maked and bundled in sctp_packet_bundle_sack.

Reported-by: Ja Ram Jeon <jajeon@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9fae5418

net/sctp/output.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -282,6 +282,9 @@ static enum sctp_xmit sctp_packet_bundle_sack(struct sctp_packet *pkt,
		sctp_chunk_free(sack);
		goto out;
		}
		SCTP_INC_STATS(sock_net(asoc->base.sk),
		SCTP_MIB_OUTCTRLCHUNKS);
		asoc->stats.octrlchunks++;
		asoc->peer.sack_needed = 0;
		if (del_timer(timer))
		sctp_association_put(asoc);

Admin message