Commit 7aed9f72 authored Jun 07, 2017 by Jason A. Donenfeld Committed by Theodore Ts'o Jun 19, 2017

net/route: use get_random_int for random counter



Using get_random_int here is faster, more fitting of the use case, and
just as cryptographically secure. It also has the benefit of providing
better randomness at early boot, which is when many of these structures
are assigned.

Also, semantically, it's not really proper to have been assigning an
atomic_t in this way before, even if in practice it works fine.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent b3d0f789

net/ipv4/route.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net)
		{
		atomic_set(&net->ipv4.rt_genid, 0);
		atomic_set(&net->fnhe_genid, 0);
		get_random_bytes(&net->ipv4.dev_addr_genid,
		sizeof(net->ipv4.dev_addr_genid));
		atomic_set(&net->ipv4.dev_addr_genid, get_random_int());
		return 0;
		}

Admin message