Commit 7ae3cb15 authored Nov 05, 2015 by Vinod Koul Committed by Mark Brown Nov 16, 2015

ASoC: Intel: Skylake: Fix resource cleanup on teardown



MCPS free was being done from PGA context which will free up MCPS
for only last modules in a pipe and not the rest causing MCPS
leak and eventual audio loss due to no "free" MCPS.

This needs to be freed for every module while cleaning up the
modules, so move the check to
skl_tplg_mixer_dapm_post_pmd_event()

Signed-off-by: Mohan Krishna Velaga <mohan.krishnax.velaga@intel.com>
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent c7b2a444

sound/soc/intel/skylake/skl-topology.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -640,6 +640,7 @@ static int skl_tplg_mixer_dapm_post_pmd_event(struct snd_soc_dapm_widget *w,
		list_for_each_entry(w_module, &s_pipe->w_list, node) {
		dst_module = w_module->w->priv;

		skl_tplg_free_pipe_mcps(skl, dst_module);
		if (src_module == NULL) {
		src_module = dst_module;
		continue;
		@@ -673,7 +674,6 @@ static int skl_tplg_pga_dapm_post_pmd_event(struct snd_soc_dapm_widget *w,

		src_mconfig = w->priv;

		skl_tplg_free_pipe_mcps(skl, src_mconfig);
		/* Stop the pipe since this is a mixin module */
		ret = skl_stop_pipe(ctx, src_mconfig->pipe);
		if (ret)

Admin message