Commit 7acf9d42 authored Jul 27, 2018 by Dmitry Safonov Committed by David S. Miller Jul 29, 2018

netlink: Do not subscribe to non-existent groups

Make ABI more strict about subscribing to group > ngroups.
Code doesn't check for that and it looks bogus.
(one can subscribe to non-existing group)
Still, it's possible to bind() to all possible groups with (-1)

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9939a46d

net/netlink/af_netlink.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1008,6 +1008,7 @@ static int netlink_bind(struct socket sock, struct sockaddr addr,
		if (err)
		return err;
		}
		groups &= (1UL << nlk->ngroups) - 1;

		bound = nlk->bound;
		if (bound) {

Admin message