Commit 7aabe84b authored Mar 04, 2017 by James Smart Committed by Martin K. Petersen Mar 06, 2017

scsi: lpfc: sanity check hrq is null before dereferencing it



From: Colin Ian King <colin.king@canonical.com>

The sanity check for hrq should be moved to before the deference
of hrq to ensure we don't perform a null pointer deference.

Detected by CoverityScan, CID#1411650 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 70e5afd5

drivers/scsi/lpfc/lpfc_sli.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -15185,17 +15185,17 @@ lpfc_mrq_create(struct lpfc_hba phba, struct lpfc_queue *hrqp,
		drq = drqp[idx];
		cq = cqp[idx];

		if (hrq->entry_count != drq->entry_count) {
		status = -EINVAL;
		goto out;
		}

		/* sanity check on queue memory */
		if (!hrq \|\| !drq \|\| !cq) {
		status = -ENODEV;
		goto out;
		}

		if (hrq->entry_count != drq->entry_count) {
		status = -EINVAL;
		goto out;
		}

		if (idx == 0) {
		bf_set(lpfc_mbx_rq_create_num_pages,
		&rq_create->u.request,

Admin message