Commit 7a76a7f3 authored Sep 22, 2017 by Colin Ian King Committed by Guenter Roeck Oct 29, 2017

hwmon: (w83793) make const array watchdog_minors static, reduces object code size



Don't populate const array watchdog_minors on the stack, instead make it
static. Makes the object code smaller by over 350 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  48019	  38144	    256	  86419	  15193	drivers/hwmon/w83793.o

After:
   text	   data	    bss	    dec	    hex	filename
  47574	  38232	    256	  86062	  1502e	drivers/hwmon/w83793.o

(gcc 6.3.0, x86-64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 762b1e88

drivers/hwmon/w83793.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1676,7 +1676,9 @@ static int w83793_probe(struct i2c_client *client,
		const struct i2c_device_id *id)
		{
		struct device *dev = &client->dev;
		const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 };
		static const int watchdog_minors[] = {
		WATCHDOG_MINOR, 212, 213, 214, 215
		};
		struct w83793_data *data;
		int i, tmp, val, err;
		int files_fan = ARRAY_SIZE(w83793_left_fan) / 7;

Admin message