Commit 7a5da02d authored by Gerald Schaefer's avatar Gerald Schaefer Committed by Martin Schwidefsky
Browse files

locking/lockdep: check for freed initmem in static_obj() 



The following warning occurred on s390:
WARNING: CPU: 0 PID: 804 at kernel/locking/lockdep.c:1025 lockdep_register_key+0x30/0x150

This is because the check in static_obj() assumes that all memory within
[_stext, _end] belongs to static objects, which at least for s390 isn't
true. The init section is also part of this range, and freeing it allows
the buddy allocator to allocate memory from it. We have virt == phys for
the kernel on s390, so that such allocations would then have addresses
within the range [_stext, _end].

To fix this, introduce arch_is_kernel_initmem_freed(), similar to
arch_is_kernel_text/data(), and add it to the checks in static_obj().
This will always return 0 on architectures that do not define
arch_is_kernel_initmem_freed. On s390, it will return 1 if initmem has
been freed and the address is in the range [__init_begin, __init_end].

Signed-off-by: default avatarGerald Schaefer <gerald.schaefer@de.ibm.com>
Reviewed-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent b2d24b97

arch/s390/include/asm/sections.h

+12 −0
Original line number Diff line number Diff line
@@ -2,8 +2,20 @@ 
#ifndef _S390_SECTIONS_H

#define _S390_SECTIONS_H



#define arch_is_kernel_initmem_freed arch_is_kernel_initmem_freed



#include <asm-generic/sections.h>



extern bool initmem_freed;



static inline int arch_is_kernel_initmem_freed(unsigned long addr)

{

	if (!initmem_freed)

		return 0;

	return addr >= (unsigned long)__init_begin &&

	       addr < (unsigned long)__init_end;

}



/*

 * .boot.data section contains variables "shared" between the decompressor and

 * the decompressed kernel. The decompressor will store values in them, and

arch/s390/mm/init.c

+3 −0
Original line number Diff line number Diff line
@@ -49,6 +49,8 @@ unsigned long empty_zero_page, zero_page_mask; 
EXPORT_SYMBOL(empty_zero_page);

EXPORT_SYMBOL(zero_page_mask);



bool initmem_freed;



static void __init setup_zero_pages(void)

{

	unsigned int order;
@@ -148,6 +150,7 @@ void __init mem_init(void) 


void free_initmem(void)

{

	initmem_freed = true;

	__set_memory((unsigned long)_sinittext,

		     (unsigned long)(_einittext - _sinittext) >> PAGE_SHIFT,

		     SET_MEMORY_RW | SET_MEMORY_NX);

include/asm-generic/sections.h

+14 −0
Original line number Diff line number Diff line
@@ -77,6 +77,20 @@ static inline int arch_is_kernel_data(unsigned long addr) 
}

#endif



/*

 * Check if an address is part of freed initmem. This is needed on architectures

 * with virt == phys kernel mapping, for code that wants to check if an address

 * is part of a static object within [_stext, _end]. After initmem is freed,

 * memory can be allocated from it, and such allocations would then have

 * addresses within the range [_stext, _end].

 */

#ifndef arch_is_kernel_initmem_freed

static inline int arch_is_kernel_initmem_freed(unsigned long addr)

{

	return 0;

}

#endif



/**

 * memory_contains - checks if an object is contained within a memory region

 * @begin: virtual address of the beginning of the memory region

kernel/locking/lockdep.c

+3 −0
Original line number Diff line number Diff line
@@ -649,6 +649,9 @@ static int static_obj(const void *obj) 
		      end   = (unsigned long) &_end,

		      addr  = (unsigned long) obj;



	if (arch_is_kernel_initmem_freed(addr))

		return 0;



	/*

	 * static variable?

	 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE