Commit 7a3c5677 authored Mar 10, 2015 by Doug Anderson Committed by Ulf Hansson Jul 25, 2016

mmc: dw_mmc: Consider HLE errors to be data and command errors



The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but
nothing in the interrupt handler actually handles them and ACKs them.
That means that if we ever get an HLE error we'll just keep getting
interrupts and we'll wedge things.

We really don't expect HLE errors but if we ever get them we shouldn't
silently ignore them.

Note that I have seen HLE errors while constantly ejecting and
inserting cards (ejecting while inserting, etc).

Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent af637629

drivers/mmc/host/dw_mmc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -44,11 +44,11 @@
		/* Common flag combinations */
		#define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO \| SDMMC_INT_DCRC \| \
		SDMMC_INT_HTO \| SDMMC_INT_SBE \| \
		SDMMC_INT_EBE)
		SDMMC_INT_EBE \| SDMMC_INT_HLE)
		#define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO \| SDMMC_INT_RCRC \| \
		SDMMC_INT_RESP_ERR)
		SDMMC_INT_RESP_ERR \| SDMMC_INT_HLE)
		#define DW_MCI_ERROR_FLAGS (DW_MCI_DATA_ERROR_FLAGS \| \
		DW_MCI_CMD_ERROR_FLAGS \| SDMMC_INT_HLE)
		DW_MCI_CMD_ERROR_FLAGS)
		#define DW_MCI_SEND_STATUS 1
		#define DW_MCI_RECV_STATUS 2
		#define DW_MCI_DMA_THRESHOLD 16

Admin message