Commit 7a379558 authored Jul 24, 2020 by Tom Parkin Committed by David S. Miller Jul 24, 2020

l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start



l2tp_dfs_seq_start had a BUG_ON to catch a possible programming error in
l2tp_dfs_seq_open.

Since we can easily bail out of l2tp_dfs_seq_start, prefer to do that
and flag the error with a WARN_ON rather than crashing the kernel.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 95075150

net/l2tp/l2tp_debugfs.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -72,7 +72,10 @@ static void l2tp_dfs_seq_start(struct seq_file m, loff_t *offs)
		if (!pos)
		goto out;

		BUG_ON(!m->private);
		if (WARN_ON(!m->private)) {
		pd = NULL;
		goto out;
		}
		pd = m->private;

		if (!pd->tunnel)

Admin message