Commit 7a366707 authored Sep 14, 2020 by Sibi Sankar Committed by Bjorn Andersson Sep 14, 2020

soc: qcom: pdr: Fixup array type of get_domain_list_resp message



The array type of get_domain_list_resp is incorrectly marked as NO_ARRAY.
Due to which the following error was observed when using pdr helpers with
the downstream proprietary pd-mapper. Fix this up by marking it as
VAR_LEN_ARRAY instead.

Err logs:
qmi_decode_struct_elem: Fault in decoding: dl(2), db(27), tl(160), i(1), el(1)
failed to decode incoming message
PDR: tms/servreg get domain list txn wait failed: -14
PDR: service lookup for tms/servreg failed: -14

Tested-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Fixes: fbe639b4 ("soc: qcom: Introduce Protection Domain Restart helpers")
Reported-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Link: https://lore.kernel.org/r/20200914145807.1224-1-sibis@codeaurora.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 9123e3a7

drivers/soc/qcom/pdr_internal.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -185,7 +185,7 @@ struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {
		.data_type = QMI_STRUCT,
		.elem_len = SERVREG_DOMAIN_LIST_LENGTH,
		.elem_size = sizeof(struct servreg_location_entry),
		.array_type = NO_ARRAY,
		.array_type = VAR_LEN_ARRAY,
		.tlv_type = 0x12,
		.offset = offsetof(struct servreg_get_domain_list_resp,
		domain_list),

Admin message