Commit 7a2e8aaf authored Jun 21, 2013 by Takuya Yoshikawa Committed by Gleb Natapov Jun 27, 2013

KVM: MMU: Inform users of mmio generation wraparound

Without this information, users will just see unexpected performance
problems and there is little chance we will get good reports from them:
note that mmio generation is increased even when we just start, or stop,
dirty logging for some memory slot, in which case users cannot expect
all shadow pages to be zapped.

printk_ratelimited() is used for this taking into account the problems
that we can see the information many times when we start multiple VMs
and guests can trigger this by reading ROM in a loop for example.

Signed-off-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 5a9b3830

arch/x86/kvm/mmu.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -4387,9 +4387,11 @@ void kvm_mmu_invalidate_mmio_sptes(struct kvm *kvm)
		* The max value is MMIO_MAX_GEN - 1 since it is not called
		* when mark memslot invalid.
		*/
		if (unlikely(kvm_current_mmio_generation(kvm) >= (MMIO_MAX_GEN - 1)))
		if (unlikely(kvm_current_mmio_generation(kvm) >= (MMIO_MAX_GEN - 1))) {
		printk_ratelimited(KERN_INFO "kvm: zapping shadow pages for mmio generation wraparound\n");
		kvm_mmu_invalidate_zap_all_pages(kvm);
		}
		}

		static int mmu_shrink(struct shrinker shrink, struct shrink_control sc)
		{

Admin message