Commit 7a1cd723 authored by Milan Broz's avatar Milan Broz Committed by Mike Snitzer
Browse files

dm crypt: move detailed message into debug level 



The information about tag size should not be printed without debug info
set. Also print device major:minor in the error message to identify the
device instance.

Also use rate limiting and debug level for info about used crypto API
implementaton.  This is important because during online reencryption
the existing message saturates syslog (because we are moving hotzone
across the whole device).

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMilan Broz <gmazyland@gmail.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 0f41fcf7

drivers/md/dm-crypt.c

+5 −4
Original line number Diff line number Diff line
@@ -949,6 +949,7 @@ static int crypt_integrity_ctr(struct crypt_config *cc, struct dm_target *ti) 
{

#ifdef CONFIG_BLK_DEV_INTEGRITY

	struct blk_integrity *bi = blk_get_integrity(cc->dev->bdev->bd_disk);

	struct mapped_device *md = dm_table_get_md(ti->table);



	/* From now we require underlying device with our integrity profile */

	if (!bi || strcasecmp(bi->profile->name, "DM-DIF-EXT-TAG")) {
@@ -968,7 +969,7 @@ static int crypt_integrity_ctr(struct crypt_config *cc, struct dm_target *ti) 


	if (crypt_integrity_aead(cc)) {

		cc->integrity_tag_size = cc->on_disk_tag_size - cc->integrity_iv_size;

		DMINFO("Integrity AEAD, tag size %u, IV size %u.",

		DMDEBUG("%s: Integrity AEAD, tag size %u, IV size %u.", dm_device_name(md),

		       cc->integrity_tag_size, cc->integrity_iv_size);



		if (crypto_aead_setauthsize(any_tfm_aead(cc), cc->integrity_tag_size)) {
@@ -976,7 +977,7 @@ static int crypt_integrity_ctr(struct crypt_config *cc, struct dm_target *ti) 
			return -EINVAL;

		}

	} else if (cc->integrity_iv_size)

		DMINFO("Additional per-sector space %u bytes for IV.",

		DMDEBUG("%s: Additional per-sector space %u bytes for IV.", dm_device_name(md),

		       cc->integrity_iv_size);



	if ((cc->integrity_tag_size + cc->integrity_iv_size) != bi->tag_size) {
@@ -1891,7 +1892,7 @@ static int crypt_alloc_tfms_skcipher(struct crypt_config *cc, char *ciphermode) 
	 * algorithm implementation is used.  Help people debug performance

	 * problems by logging the ->cra_driver_name.

	 */

	DMINFO("%s using implementation \"%s\"", ciphermode,

	DMDEBUG_LIMIT("%s using implementation \"%s\"", ciphermode,

	       crypto_skcipher_alg(any_tfm(cc))->base.cra_driver_name);

	return 0;

}
@@ -1911,7 +1912,7 @@ static int crypt_alloc_tfms_aead(struct crypt_config *cc, char *ciphermode) 
		return err;

	}



	DMINFO("%s using implementation \"%s\"", ciphermode,

	DMDEBUG_LIMIT("%s using implementation \"%s\"", ciphermode,

	       crypto_aead_alg(any_tfm_aead(cc))->base.cra_driver_name);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE