Commit 7a0d7961 authored Sep 19, 2019 by Linus Torvalds

linux

Pull orangefs updates from Mike Marshall:
 "A fix and a cleanup.

  The fix: way back in the stone age (2003) mode was set to the magic
  number "755" in what is now fs/orangefs/namei.c(orangefs_symlink).
  Łukasz Wrochna reported it and Artur Świgoń sent in a patch to change
  it to octal. Maybe it shouldn't be a magic number at all but rather
  something like "S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH"...

  cleanup: Colin Ian King found a redundant assignment and sent in a
  patch to remove it"

[ And no, octal numbers for permissions are a lot more legible than a
  binary 'or' of some line noise macros. So 0755 is preferred over
  trying to spell it out using "helpful" macros     - Linus ]

* tag 'for-linus-5.4-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux:
  orangefs: remove redundant assignment to err
  orangefs: Add octal zero prefix

parents 8e6ee05d e6b998ab

fs/orangefs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -940,7 +940,7 @@ out:
		int orangefs_getattr(const struct path path, struct kstat stat,
		u32 request_mask, unsigned int flags)
		{
		int ret = -ENOENT;
		int ret;
		struct inode *inode = path->dentry->d_inode;

		gossip_debug(GOSSIP_INODE_DEBUG,

fs/orangefs/namei.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -224,7 +224,7 @@ static int orangefs_symlink(struct inode *dir,
		struct orangefs_object_kref ref;
		struct inode *inode;
		struct iattr iattr;
		int mode = 755;
		int mode = 0755;
		int ret;

		gossip_debug(GOSSIP_NAME_DEBUG, "%s: called\n", __func__);

Admin message