Commit 7a096d57 authored Jun 12, 2019 by Vlad Buslov Committed by David S. Miller Jun 12, 2019

net: sched: ingress: set 'unlocked' flag for Qdisc ops

To remove rtnl lock dependency in tc filter update API when using ingress
Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in ingress Qdisc_class_ops.

Ingress Qdisc ops don't require any modifications to be used without rtnl
lock on tc filter update path. Ingress implementation never changes its
q->block and only releases it when Qdisc is being destroyed. This means it
is enough for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to
hold ingress Qdisc reference while using it without relying on rtnl lock
protection. Unlocked Qdisc ops support is already implemented in filter
update path by unlocked cls API patch set.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 758a0a4d

net/sched/sch_ingress.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -114,6 +114,7 @@ nla_put_failure:
		}

		static const struct Qdisc_class_ops ingress_class_ops = {
		.flags = QDISC_CLASS_OPS_DOIT_UNLOCKED,
		.leaf = ingress_leaf,
		.find = ingress_find,
		.walk = ingress_walk,

Admin message