Commit 7a014a87 authored by Ben Skeggs's avatar Ben Skeggs
Browse files

drm/nouveau/disp: add internal representaion of output paths and connectors



This will, at some point, be used to replace various bits and pieces of
code doing direct bios parsing.  For now, it'll just be used for some
DP improvements.

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 20014cbe
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -222,6 +222,8 @@ nouveau-y += core/engine/device/nvc0.o
nouveau-y += core/engine/device/nve0.o
nouveau-y += core/engine/device/gm100.o
nouveau-y += core/engine/disp/base.o
nouveau-y += core/engine/disp/conn.o
nouveau-y += core/engine/disp/outp.o
nouveau-y += core/engine/disp/nv04.o
nouveau-y += core/engine/disp/nv50.o
nouveau-y += core/engine/disp/nv84.o
+103 −2
Original line number Diff line number Diff line
@@ -23,25 +23,86 @@
 */

#include "priv.h"
#include "outp.h"
#include "conn.h"

static int
nouveau_disp_hpd_check(struct nouveau_event *event, u32 types, int index)
{
	struct nouveau_disp *disp = event->priv;
	struct nvkm_output *outp;
	list_for_each_entry(outp, &disp->outp, head) {
		if (outp->conn->index == index) {
			if (outp->conn->hpd.event)
				return 0;
			break;
		}
	}
	return -ENOSYS;
}

int
_nouveau_disp_fini(struct nouveau_object *object, bool suspend)
{
	struct nouveau_disp *disp = (void *)object;
	struct nvkm_output *outp;
	int ret;

	list_for_each_entry(outp, &disp->outp, head) {
		ret = nv_ofuncs(outp)->fini(nv_object(outp), suspend);
		if (ret && suspend)
			goto fail_outp;
	}

	return nouveau_engine_fini(&disp->base, suspend);

fail_outp:
	list_for_each_entry_continue_reverse(outp, &disp->outp, head) {
		nv_ofuncs(outp)->init(nv_object(outp));
	}

	return ret;
}

int
_nouveau_disp_init(struct nouveau_object *object)
{
	return 0;
	struct nouveau_disp *disp = (void *)object;
	struct nvkm_output *outp;
	int ret;

	ret = nouveau_engine_init(&disp->base);
	if (ret)
		return ret;

	list_for_each_entry(outp, &disp->outp, head) {
		ret = nv_ofuncs(outp)->init(nv_object(outp));
		if (ret)
			goto fail_outp;
	}

	return ret;

fail_outp:
	list_for_each_entry_continue_reverse(outp, &disp->outp, head) {
		nv_ofuncs(outp)->fini(nv_object(outp), false);
	}

	return ret;
}

void
_nouveau_disp_dtor(struct nouveau_object *object)
{
	struct nouveau_disp *disp = (void *)object;
	struct nvkm_output *outp, *outt;

	nouveau_event_destroy(&disp->vblank);

	list_for_each_entry_safe(outp, outt, &disp->outp, head) {
		nouveau_object_ref(NULL, (struct nouveau_object **)&outp);
	}

	nouveau_engine_destroy(&disp->base);
}

@@ -52,8 +113,15 @@ nouveau_disp_create_(struct nouveau_object *parent,
		     const char *intname, const char *extname,
		     int length, void **pobject)
{
	struct nouveau_disp_impl *impl = (void *)oclass;
	struct nouveau_bios *bios = nouveau_bios(parent);
	struct nouveau_disp *disp;
	int ret;
	struct nouveau_oclass **sclass;
	struct nouveau_object *object;
	struct dcb_output dcbE;
	u8  hpd = 0, ver, hdr;
	u32 data;
	int ret, i;

	ret = nouveau_engine_create_(parent, engine, oclass, true,
				     intname, extname, length, pobject);
@@ -61,6 +129,39 @@ nouveau_disp_create_(struct nouveau_object *parent,
	if (ret)
		return ret;

	INIT_LIST_HEAD(&disp->outp);

	/* create output objects for each display path in the vbios */
	i = -1;
	while ((data = dcb_outp_parse(bios, ++i, &ver, &hdr, &dcbE))) {
		if (dcbE.type == DCB_OUTPUT_UNUSED)
			continue;
		if (dcbE.type == DCB_OUTPUT_EOL)
			break;
		data = dcbE.location << 4 | dcbE.type;

		oclass = nvkm_output_oclass;
		sclass = impl->outp;
		while (sclass && sclass[0]) {
			if (sclass[0]->handle == data) {
				oclass = sclass[0];
				break;
			}
			sclass++;
		}

		nouveau_object_ctor(*pobject, *pobject, oclass,
				    &dcbE, i, &object);
		hpd = max(hpd, (u8)(dcbE.connector + 1));
	}

	ret = nouveau_event_create(3, hpd, &disp->hpd);
	if (ret)
		return ret;

	disp->hpd->priv = disp;
	disp->hpd->check = nouveau_disp_hpd_check;

	ret = nouveau_event_create(1, heads, &disp->vblank);
	if (ret)
		return ret;
+172 −0
Original line number Diff line number Diff line
/*
 * Copyright 2014 Red Hat Inc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 * OTHER DEALINGS IN THE SOFTWARE.
 *
 * Authors: Ben Skeggs
 */

#include <subdev/gpio.h>

#include "conn.h"
#include "outp.h"

static void
nvkm_connector_hpd_work(struct work_struct *w)
{
	struct nvkm_connector *conn = container_of(w, typeof(*conn), hpd.work);
	struct nouveau_disp *disp = nouveau_disp(conn);
	struct nouveau_gpio *gpio = nouveau_gpio(conn);
	u32 send = NVKM_HPD_UNPLUG;
	if (gpio->get(gpio, 0, DCB_GPIO_UNUSED, conn->hpd.event->index))
		send = NVKM_HPD_PLUG;
	nouveau_event_trigger(disp->hpd, send, conn->index);
	nouveau_event_get(conn->hpd.event);
}

static int
nvkm_connector_hpd(void *data, u32 type, int index)
{
	struct nvkm_connector *conn = data;
	DBG("HPD: %d\n", type);
	schedule_work(&conn->hpd.work);
	return NVKM_EVENT_DROP;
}

int
_nvkm_connector_fini(struct nouveau_object *object, bool suspend)
{
	struct nvkm_connector *conn = (void *)object;
	if (conn->hpd.event)
		nouveau_event_put(conn->hpd.event);
	return nouveau_object_fini(&conn->base, suspend);
}

int
_nvkm_connector_init(struct nouveau_object *object)
{
	struct nvkm_connector *conn = (void *)object;
	int ret = nouveau_object_init(&conn->base);
	if (ret == 0) {
		if (conn->hpd.event)
			nouveau_event_get(conn->hpd.event);
	}
	return ret;
}

void
_nvkm_connector_dtor(struct nouveau_object *object)
{
	struct nvkm_connector *conn = (void *)object;
	nouveau_event_ref(NULL, &conn->hpd.event);
	nouveau_object_destroy(&conn->base);
}

int
nvkm_connector_create_(struct nouveau_object *parent,
		       struct nouveau_object *engine,
		       struct nouveau_oclass *oclass,
		       struct nvbios_connE *info, int index,
		       int length, void **pobject)
{
	static const u8 hpd[] = { 0x07, 0x08, 0x51, 0x52, 0x5e, 0x5f, 0x60 };
	struct nouveau_gpio *gpio = nouveau_gpio(parent);
	struct nouveau_disp *disp = (void *)engine;
	struct nvkm_connector *conn;
	struct nvkm_output *outp;
	struct dcb_gpio_func func;
	int ret;

	list_for_each_entry(outp, &disp->outp, head) {
		if (outp->conn && outp->conn->index == index) {
			atomic_inc(&nv_object(outp->conn)->refcount);
			*pobject = outp->conn;
			return 1;
		}
	}

	ret = nouveau_object_create_(parent, engine, oclass, 0, length, pobject);
	conn = *pobject;
	if (ret)
		return ret;

	conn->info = *info;
	conn->index = index;

	DBG("type %02x loc %d hpd %02x dp %x di %x sr %x lcdid %x\n",
	    info->type, info->location, info->hpd, info->dp,
	    info->di, info->sr, info->lcdid);

	if ((info->hpd = ffs(info->hpd))) {
		if (--info->hpd >= ARRAY_SIZE(hpd)) {
			ERR("hpd %02x unknown\n", info->hpd);
			goto done;
		}
		info->hpd = hpd[info->hpd];

		ret = gpio->find(gpio, 0, info->hpd, DCB_GPIO_UNUSED, &func);
		if (ret) {
			ERR("func %02x lookup failed, %d\n", info->hpd, ret);
			goto done;
		}

		ret = nouveau_event_new(gpio->events, NVKM_GPIO_TOGGLED,
					func.line, nvkm_connector_hpd,
					conn, &conn->hpd.event);
		if (ret) {
			ERR("func %02x failed, %d\n", info->hpd, ret);
		} else {
			DBG("func %02x (HPD)\n", info->hpd);
		}
	}

done:
	INIT_WORK(&conn->hpd.work, nvkm_connector_hpd_work);
	return 0;
}

int
_nvkm_connector_ctor(struct nouveau_object *parent,
		     struct nouveau_object *engine,
		     struct nouveau_oclass *oclass, void *info, u32 index,
		     struct nouveau_object **pobject)
{
	struct nvkm_connector *conn;
	int ret;

	ret = nvkm_connector_create(parent, engine, oclass, info, index, &conn);
	*pobject = nv_object(conn);
	if (ret)
		return ret;

	return 0;
}

struct nouveau_oclass *
nvkm_connector_oclass = &(struct nvkm_connector_impl) {
	.base = {
		.handle = 0,
		.ofuncs = &(struct nouveau_ofuncs) {
			.ctor = _nvkm_connector_ctor,
			.dtor = _nvkm_connector_dtor,
			.init = _nvkm_connector_init,
			.fini = _nvkm_connector_fini,
		},
	},
}.base;
+59 −0
Original line number Diff line number Diff line
#ifndef __NVKM_DISP_CONN_H__
#define __NVKM_DISP_CONN_H__

#include "priv.h"

struct nvkm_connector {
	struct nouveau_object base;
	struct list_head head;

	struct nvbios_connE info;
	int index;

	struct {
		struct nouveau_eventh *event;
		struct work_struct work;
	} hpd;
};

#define nvkm_connector_create(p,e,c,b,i,d)                                     \
	nvkm_connector_create_((p), (e), (c), (b), (i), sizeof(**d), (void **)d)
#define nvkm_connector_destroy(d) ({                                           \
	struct nvkm_connector *disp = (d);                                     \
	_nvkm_connector_dtor(nv_object(disp));                                 \
})
#define nvkm_connector_init(d) ({                                              \
	struct nvkm_connector *disp = (d);                                     \
	_nvkm_connector_init(nv_object(disp));                                 \
})
#define nvkm_connector_fini(d,s) ({                                            \
	struct nvkm_connector *disp = (d);                                     \
	_nvkm_connector_fini(nv_object(disp), (s));                            \
})

int nvkm_connector_create_(struct nouveau_object *, struct nouveau_object *,
			   struct nouveau_oclass *, struct nvbios_connE *,
			   int, int, void **);

int  _nvkm_connector_ctor(struct nouveau_object *, struct nouveau_object *,
			  struct nouveau_oclass *, void *, u32,
			  struct nouveau_object **);
void _nvkm_connector_dtor(struct nouveau_object *);
int  _nvkm_connector_init(struct nouveau_object *);
int  _nvkm_connector_fini(struct nouveau_object *, bool);

struct nvkm_connector_impl {
	struct nouveau_oclass base;
};

#ifndef MSG
#define MSG(l,f,a...) do {                                                     \
	struct nvkm_connector *_conn = (void *)conn;                           \
	nv_##l(nv_object(conn)->engine, "%02x:%02x%02x: "f, _conn->index,      \
	       _conn->info.location, _conn->info.type, ##a);                   \
} while(0)
#define DBG(f,a...) MSG(debug, f, ##a)
#define ERR(f,a...) MSG(error, f, ##a)
#endif

#endif
+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@

#include "dport.h"
#include "priv.h"
#include "outp.h"

struct nv50_disp_impl {
	struct nouveau_disp_impl base;
Loading