Commit 79ef9149 authored Jan 13, 2020 by Alexandru Tachici Committed by Jonathan Cameron Jan 18, 2020

iio: adc: ad7124: Set IRQ type to falling



Ad7124 data-sheet specifies that the falling edge
of the DOUT line should be used for an interrupt.
The current irq flag (IRQF_TRIGGER_LOW) used will
cause unwanted behaviour. When enabling the interrupt
it will fire once because the DOUT line is already low.
This will make the driver to read an unfinished conversion
from the chip.

This patch sets the irq type to the one specified in
the data-sheet.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent da4d3d6b

drivers/iio/adc/ad7124.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -225,7 +225,7 @@ static const struct ad_sigma_delta_info ad7124_sigma_delta_info = {
		.addr_shift = 0,
		.read_mask = BIT(6),
		.data_reg = AD7124_DATA,
		.irq_flags = IRQF_TRIGGER_LOW,
		.irq_flags = IRQF_TRIGGER_FALLING,
		};

		static int ad7124_set_channel_odr(struct ad7124_state *st,

Admin message