Commit 79d95a19 authored by Marcel Holtmann's avatar Marcel Holtmann Committed by Johan Hedberg
Browse files

Bluetooth: Remove pointless bdaddr_to_le() helper function 



The bdaddr_to_le() function tries to convert the internal address
type to one that matches the HCI address type for LE. It does not
handle any address types not used by LE and in the end just make
the code a lot harder to read.

So instead of just hiding behind a magic function, just convert
the internal address type where it needs to be converted. And it
turns out that these are only two cases anyway. One when creating
new LE connections and the other when loading the long term keys.
In both cases this makes it more clear on what it going on.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
parent a4de24d4

include/net/bluetooth/hci_core.h

+0 −2
Original line number Diff line number Diff line
@@ -1187,8 +1187,6 @@ void hci_le_conn_update(struct hci_conn *conn, u16 min, u16 max, 
void hci_le_start_enc(struct hci_conn *conn, __le16 ediv, __u8 rand[8],

							__u8 ltk[16]);



u8 bdaddr_to_le(u8 bdaddr_type);



#define SCO_AIRMODE_MASK       0x0003

#define SCO_AIRMODE_CVSD       0x0000

#define SCO_AIRMODE_TRANSP     0x0003

net/bluetooth/hci_conn.c

+4 −1
Original line number Diff line number Diff line
@@ -622,7 +622,10 @@ static struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst, 
	if (!conn)

		return ERR_PTR(-ENOMEM);



	conn->dst_type = bdaddr_to_le(dst_type);

	if (dst_type == BDADDR_LE_PUBLIC)

		conn->dst_type = ADDR_LE_DEV_PUBLIC;

	else

		conn->dst_type = ADDR_LE_DEV_RANDOM;

	conn->state = BT_CONNECT;

	conn->out = true;

	conn->link_mode |= HCI_LM_MASTER;

net/bluetooth/hci_core.c

+0 −12
Original line number Diff line number Diff line
@@ -3695,15 +3695,3 @@ static void hci_cmd_work(struct work_struct *work) 
		}

	}

}
 


u8 bdaddr_to_le(u8 bdaddr_type)

{

	switch (bdaddr_type) {

	case BDADDR_LE_PUBLIC:

		return ADDR_LE_DEV_PUBLIC;



	default:

		/* Fallback to LE Random address type */

		return ADDR_LE_DEV_RANDOM;

	}

}

net/bluetooth/mgmt.c

+7 −3
Original line number Diff line number Diff line
@@ -3678,15 +3678,19 @@ static int load_long_term_keys(struct sock *sk, struct hci_dev *hdev, 


	for (i = 0; i < key_count; i++) {

		struct mgmt_ltk_info *key = &cp->keys[i];

		u8 type;

		u8 type, addr_type;



		if (key->addr.type == BDADDR_LE_PUBLIC)

			addr_type = ADDR_LE_DEV_PUBLIC;

		else

			addr_type = ADDR_LE_DEV_RANDOM;



		if (key->master)

			type = HCI_SMP_LTK;

		else

			type = HCI_SMP_LTK_SLAVE;



		hci_add_ltk(hdev, &key->addr.bdaddr,

			    bdaddr_to_le(key->addr.type),

		hci_add_ltk(hdev, &key->addr.bdaddr, addr_type,

			    type, 0, key->authenticated, key->val,

			    key->enc_size, key->ediv, key->rand);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE