sched/fair: Remove unnecessary parameter for group_classify() (79a89f92) · Commits · 戴 / test

The group_classify() function does not use the "env" parameter, so remove it. Also unify code to always use group_classify() to calculate group's load type. Signed-off-by:

Leo Yan <leo.yan@linaro.org> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1442314605-14838-1-git-send-email-leo.yan@linaro.org Signed-off-by:

Ingo Molnar <mingo@kernel.org>

kernel/sched/fair.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -6273,8 +6273,8 @@ group_is_overloaded(struct lb_env env, struct sg_lb_stats sgs)
		return false;
		}

		static enum group_type group_classify(struct lb_env *env,
		struct sched_group *group,
		static inline enum
		group_type group_classify(struct sched_group *group,
		struct sg_lb_stats *sgs)
		{
		if (sgs->group_no_capacity)
		@@ -6340,7 +6340,7 @@ static inline void update_sg_lb_stats(struct lb_env *env,
		sgs->group_weight = group->group_weight;

		sgs->group_no_capacity = group_is_overloaded(env, sgs);
		sgs->group_type = group_classify(env, group, sgs);
		sgs->group_type = group_classify(group, sgs);
		}

		/**
		@@ -6474,7 +6474,7 @@ static inline void update_sd_lb_stats(struct lb_env env, struct sd_lb_stats sd
		group_has_capacity(env, &sds->local_stat) &&
		(sgs->sum_nr_running > 1)) {
		sgs->group_no_capacity = 1;
		sgs->group_type = group_overloaded;
		sgs->group_type = group_classify(sg, sgs);
		}

		if (update_sd_pick_busiest(env, sds, sg, sgs)) {

Admin message