Commit 7984754b authored by Kees Cook's avatar Kees Cook Committed by Linus Torvalds
Browse files

kexec: add sysctl to disable kexec_load 



For general-purpose (i.e.  distro) kernel builds it makes sense to build
with CONFIG_KEXEC to allow end users to choose what kind of things they
want to do with kexec.  However, in the face of trying to lock down a
system with such a kernel, there needs to be a way to disable kexec_load
(much like module loading can be disabled).  Without this, it is too easy
for the root user to modify kernel memory even when CONFIG_STRICT_DEVMEM
and modules_disabled are set.  With this change, it is still possible to
load an image for use later, then disable kexec_load so the image (or lack
of image) can't be altered.

The intention is for using this in environments where "perfect"
enforcement is hard.  Without a verified boot, along with verified
modules, and along with verified kexec, this is trying to give a system a
better chance to defend itself (or at least grow the window of
discoverability) against attack in the face of a privilege escalation.

In my mind, I consider several boot scenarios:

1) Verified boot of read-only verified root fs loading fd-based
   verification of kexec images.
2) Secure boot of writable root fs loading signed kexec images.
3) Regular boot loading kexec (e.g. kcrash) image early and locking it.
4) Regular boot with no control of kexec image at all.

1 and 2 don't exist yet, but will soon once the verified kexec series has
landed.  4 is the state of things now.  The gap between 2 and 4 is too
large, so this change creates scenario 3, a middle-ground above 4 when 2
and 1 are not possible for a system.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarRik van Riel <riel@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3b96d7db

Documentation/sysctl/kernel.txt

+14 −1
Original line number Original line Diff line number Diff line
@@ -33,6 +33,7 @@ show up in /proc/sys/kernel: 
- domainname

- domainname

- hostname

- hostname

- hotplug

- hotplug

- kexec_load_disabled

- kptr_restrict

- kptr_restrict

- kstack_depth_to_print       [ X86 only ]

- kstack_depth_to_print       [ X86 only ]

- l2cr                        [ PPC only ]

- l2cr                        [ PPC only ]
@@ -287,6 +288,18 @@ Default value is "/sbin/hotplug". 




==============================================================

==============================================================





kexec_load_disabled:



A toggle indicating if the kexec_load syscall has been disabled. This

value defaults to 0 (false: kexec_load enabled), but can be set to 1

(true: kexec_load disabled). Once true, kexec can no longer be used, and

the toggle cannot be set back to false. This allows a kexec image to be

loaded before disabling the syscall, allowing a system to set up (and

later use) an image without it being altered. Generally used together

with the "modules_disabled" sysctl.



==============================================================



kptr_restrict:

kptr_restrict:





This toggle indicates whether restrictions are placed on

This toggle indicates whether restrictions are placed on
@@ -331,7 +344,7 @@ A toggle value indicating if modules are allowed to be loaded 
in an otherwise modular kernel.  This toggle defaults to off

in an otherwise modular kernel.  This toggle defaults to off

(0), but can be set true (1).  Once true, modules can be

(0), but can be set true (1).  Once true, modules can be

neither loaded nor unloaded, and the toggle cannot be set back

neither loaded nor unloaded, and the toggle cannot be set back

to false.

to false.  Generally used with the "kexec_load_disabled" toggle.





==============================================================

==============================================================

include/linux/kexec.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -170,6 +170,7 @@ unsigned long paddr_vmcoreinfo_note(void); 




extern struct kimage *kexec_image;

extern struct kimage *kexec_image;

extern struct kimage *kexec_crash_image;

extern struct kimage *kexec_crash_image;

extern int kexec_load_disabled;





#ifndef kexec_flush_icache_page

#ifndef kexec_flush_icache_page

#define kexec_flush_icache_page(page)

#define kexec_flush_icache_page(page)

kernel/kexec.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -932,6 +932,7 @@ static int kimage_load_segment(struct kimage *image, 
 */

 */

struct kimage *kexec_image;

struct kimage *kexec_image;

struct kimage *kexec_crash_image;

struct kimage *kexec_crash_image;

int kexec_load_disabled;





static DEFINE_MUTEX(kexec_mutex);

static DEFINE_MUTEX(kexec_mutex);
@@ -942,7 +943,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, 
	int result;

	int result;





	/* We only trust the superuser with rebooting the system. */

	/* We only trust the superuser with rebooting the system. */

	if (!capable(CAP_SYS_BOOT))

	if (!capable(CAP_SYS_BOOT) || kexec_load_disabled)

		return -EPERM;

		return -EPERM;





	/*

	/*

kernel/sysctl.c

+13 −0
Original line number Original line Diff line number Diff line
@@ -62,6 +62,7 @@ 
#include <linux/capability.h>

#include <linux/capability.h>

#include <linux/binfmts.h>

#include <linux/binfmts.h>

#include <linux/sched/sysctl.h>

#include <linux/sched/sysctl.h>

#include <linux/kexec.h>





#include <asm/uaccess.h>

#include <asm/uaccess.h>

#include <asm/processor.h>

#include <asm/processor.h>
@@ -614,6 +615,18 @@ static struct ctl_table kern_table[] = { 
		.proc_handler	= proc_dointvec,

		.proc_handler	= proc_dointvec,

	},

	},

#endif

#endif

#ifdef CONFIG_KEXEC

	{

		.procname	= "kexec_load_disabled",

		.data		= &kexec_load_disabled,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		/* only handle a transition from default "0" to "1" */

		.proc_handler	= proc_dointvec_minmax,

		.extra1		= &one,

		.extra2		= &one,

	},

#endif

#ifdef CONFIG_MODULES

#ifdef CONFIG_MODULES

	{

	{

		.procname	= "modprobe",

		.procname	= "modprobe",

CRA Git | Maintained and supported by SUSTech CRA and CCSE