thermal: int3400_thermal: Statically initialize .get_mode()/.set_mode() ops (79799562) · Commits · 戴 / test

int3400_thermal_ops is used inside int3400_thermal_probe() only after the assignments, which can just as well be made statically at struct's initizer. Signed-off-by:

Andrzej Pietrasiewicz <andrzej.p@collabora.com> Reviewed-by:

Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by:

Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20200414180105.20042-2-andrzej.p@collabora.com

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -271,6 +271,8 @@ static int int3400_thermal_set_mode(struct thermal_zone_device *thermal,

		static struct thermal_zone_device_ops int3400_thermal_ops = {
		.get_temp = int3400_thermal_get_temp,
		.get_mode = int3400_thermal_get_mode,
		.set_mode = int3400_thermal_set_mode,
		};

		static struct thermal_zone_params int3400_thermal_params = {
		@@ -309,9 +311,6 @@ static int int3400_thermal_probe(struct platform_device *pdev)

		platform_set_drvdata(pdev, priv);

		int3400_thermal_ops.get_mode = int3400_thermal_get_mode;
		int3400_thermal_ops.set_mode = int3400_thermal_set_mode;

		priv->thermal = thermal_zone_device_register("INT3400 Thermal", 0, 0,
		priv, &int3400_thermal_ops,
		&int3400_thermal_params, 0, 0);

Admin message