Commit 794b2bd2 authored Dec 01, 2006 by Stephen Hemminger Committed by Jeff Garzik Dec 02, 2006

[PATCH] sky2: kfree_skb_any needed

It is possible for the sky2 driver NAPI poll routine to be called with
IRQ's disabled if netpoll is trying to make space in the tx queue. This
is an obscure path, but if it happens, the kfree_skb needs to happen
via softirq. Calling kfree_skb with IRQ's disabled is a not allowed.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 8df9a876

drivers/net/sky2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1453,7 +1453,7 @@ static void sky2_tx_complete(struct sky2_port *sky2, u16 done)
		if (unlikely(netif_msg_tx_done(sky2)))
		printk(KERN_DEBUG "%s: tx done %u\n",
		dev->name, idx);
		dev_kfree_skb(re->skb);
		dev_kfree_skb_any(re->skb);
		}

		le->opcode = 0; /* paranoia */

Admin message