net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variable (7949513b) · Commits · 戴 / test

There is a risk that the variables will be used without being initialized. Have also moved variable to the part of the code where it is used. This was largely found by using a static code analysis program called cppcheck. Signed-off-by:

Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:

John W. Linville <linville@tuxdriver.com>

drivers/net/wireless/rtlwifi/rtl8192de/phy.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -203,11 +203,12 @@ u32 rtl92d_phy_query_bb_reg(struct ieee80211_hw *hw, u32 regaddr, u32 bitmask)
		struct rtl_priv *rtlpriv = rtl_priv(hw);
		struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
		u32 returnvalue, originalvalue, bitshift;
		u8 dbi_direct;

		RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, "regaddr(%#x), bitmask(%#x)\n",
		regaddr, bitmask);
		if (rtlhal->during_mac1init_radioa \|\| rtlhal->during_mac0init_radiob) {
		u8 dbi_direct = 0;

		/* mac1 use phy0 read radio_b. */
		/* mac0 use phy1 read radio_b. */
		if (rtlhal->during_mac1init_radioa)

Admin message