iwlwifi: mvm: include more debug data when we get an unexpected baid (790e6634) · Commits · 戴 / test

When we get a valid baid in a received frame, we need to check that we are aware of this baid. If not, we check that the OLD_SN bit set. If that's not the case, we issue a WARNING. Print more data when that happens. Signed-off-by:

Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:

Luca Coelho <luciano.coelho@intel.com>

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -636,8 +636,8 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm,
		baid_data = rcu_dereference(mvm->baid_map[baid]);
		if (!baid_data) {
		WARN(!(reorder & IWL_RX_MPDU_REORDER_BA_OLD_SN),
		"Received baid %d, but no data exists for this BAID\n",
		baid);
		"Received baid %d, but no data exists for this BAID - reorder data 0x%x\n",
		baid, reorder);
		return false;
		}

		@@ -758,7 +758,9 @@ static void iwl_mvm_agg_rx_received(struct iwl_mvm *mvm,

		data = rcu_dereference(mvm->baid_map[baid]);
		if (!data) {
		WARN_ON(!(reorder_data & IWL_RX_MPDU_REORDER_BA_OLD_SN));
		WARN(!(reorder_data & IWL_RX_MPDU_REORDER_BA_OLD_SN),
		"OLD_SN isn't set, but no data exists for baid %d - reorder data 0x%x\n",
		baid, reorder_data);
		goto out;
		}

Admin message