Commit 790b415c authored by Libin Yang's avatar Libin Yang Committed by Takashi Iwai
Browse files

ALSA: hda - hdmi defer to register acomp eld notifier 



Defer to register acomp eld notifier until hdmi audio driver
is fully ready.

After registering eld notifier, gfx driver can use this
callback function to notify audio driver the monitor
connection event. However this action may happen when
audio driver is adding the pins or doing other initialization.
This is not always safe, however. For example, using
per_pin->lock before the lock is initialized.

Let's register the eld notifier after the initialization is done.

Signed-off-by: default avatarLibin Yang <libin.yang@linux.intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ec75a940

sound/pci/hda/patch_hdmi.c

+12 −12
Original line number Diff line number Diff line
@@ -2477,18 +2477,6 @@ static int patch_generic_hdmi(struct hda_codec *codec) 
			is_broxton(codec))

		codec->core.link_power_control = 1;



	if (codec_has_acomp(codec)) {

		codec->depop_delay = 0;

		spec->i915_audio_ops.audio_ptr = codec;

		/* intel_audio_codec_enable() or intel_audio_codec_disable()

		 * will call pin_eld_notify with using audio_ptr pointer

		 * We need make sure audio_ptr is really setup

		 */

		wmb();

		spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify;

		snd_hdac_i915_register_notifier(&spec->i915_audio_ops);

	}



	if (hdmi_parse_codec(codec) < 0) {

		if (spec->i915_bound)

			snd_hdac_i915_exit(&codec->bus->core);
@@ -2510,6 +2498,18 @@ static int patch_generic_hdmi(struct hda_codec *codec) 


	init_channel_allocations();



	if (codec_has_acomp(codec)) {

		codec->depop_delay = 0;

		spec->i915_audio_ops.audio_ptr = codec;

		/* intel_audio_codec_enable() or intel_audio_codec_disable()

		 * will call pin_eld_notify with using audio_ptr pointer

		 * We need make sure audio_ptr is really setup

		 */

		wmb();

		spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify;

		snd_hdac_i915_register_notifier(&spec->i915_audio_ops);

	}



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE