Commit 78f2bfa3 authored Mar 02, 2020 by Guido Günther Committed by Lucas Stach Mar 03, 2020

drm/etnaviv: Warn when GPU doesn't idle fast enough



If the GPU isn't idle after signalling pm_runtime_mark_last_busy() plus
waiting for the autosuspend delay there's likely something wrong with
the way we check idleness so warn about that.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

parent 1a910c11

drivers/gpu/drm/etnaviv/etnaviv_gpu.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1839,8 +1839,11 @@ static int etnaviv_gpu_rpm_suspend(struct device *dev)
		mask = gpu->idle_mask & ~(VIVS_HI_IDLE_STATE_FE \|
		VIVS_HI_IDLE_STATE_MC);
		idle = gpu_read(gpu, VIVS_HI_IDLE_STATE) & mask;
		if (idle != mask)
		if (idle != mask) {
		dev_warn_ratelimited(dev, "GPU not yet idle, mask: 0x%08x\n",
		idle);
		return -EBUSY;
		}

		return etnaviv_gpu_hw_suspend(gpu);
		}

Admin message