Commit 78e77b7d authored Jan 14, 2020 by Srinivas Pandruvada Committed by Andy Shevchenko Jan 20, 2020

tools/power/x86/intel-speed-select: Fix result display for turbo-freq auto mode



The turbo-freq enable with auto mode, prints result for the last possible
CPU, which is not correct when either CPU is not present or user wants
command to be limited to a single die/package. For example, in the
below command user wants to limit to die/package 0, but the
"turbo-freq --auto" result is displayed using the other package.

$ sudo intel-speed-select -c 0 turbo-freq enable -a
Intel(R) Speed Select Technology
 package-0
  die-0
    cpu-0
      turbo-freq
        enable:success
 package--1
  die-0
    cpu-31
      turbo-freq --auto
        enable:success

Since we do have to traverse all CPUs, don't display CPU info for
"turbo-freq --auto", as we already displayed the result for
turbo-freq enable with the CPU information.

With the fix, the same command results in:

$ sudo intel-speed-select -c 0 turbo-freq enable -a
Intel(R) Speed Select Technology
package-0
  die-0
    cpu-0
      turbo-freq
        enable:success
      turbo-freq --auto
        enable:success

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent 645feeb2

tools/power/x86/intel-speed-select/isst-config.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1638,7 +1638,7 @@ static void set_fact_enable(int arg)
		if (ret)
		goto error_disp;
		}
		isst_display_result(i, outf, "turbo-freq --auto", "enable", 0);
		isst_display_result(-1, outf, "turbo-freq --auto", "enable", 0);
		}

		return;

tools/power/x86/intel-speed-select/isst-display.c

+9 −7

Original line number	Diff line number	Diff line
		@@ -645,6 +645,7 @@ void isst_display_result(int cpu, FILE outf, char feature, char *cmd,
		char header[256];
		char value[256];

		if (cpu >= 0) {
		snprintf(header, sizeof(header), "package-%d",
		get_physical_package_id(cpu));
		format_and_print(outf, 1, header, NULL);
		@@ -652,6 +653,7 @@ void isst_display_result(int cpu, FILE outf, char feature, char *cmd,
		format_and_print(outf, 2, header, NULL);
		snprintf(header, sizeof(header), "cpu-%d", cpu);
		format_and_print(outf, 3, header, NULL);
		}
		snprintf(header, sizeof(header), "%s", feature);
		format_and_print(outf, 4, header, NULL);
		snprintf(header, sizeof(header), "%s", cmd);

Admin message