Commit 78d81f2f authored Oct 06, 2009 by Christian Borntraeger Committed by Martin Schwidefsky Oct 06, 2009

[S390] Fix enabled udelay for short delays.



When udelay() gets called with a delay that would expire before the
next clock event it reprograms the clock comparator.
When the interrupt happens the clock comparator won't be resetted
therefore the interrupt condition doesn't get cleared.
The result is an endless timer interrupt loop until the next clock
event would expire (stored in lowcore).
So udelay() usually would wait much longer for small delays than it
should.

Fix this by disabling the local tick which makes sure that the clock
comparator will be resetted when a timer interrupt happens.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent 102e835d

arch/s390/lib/delay.c

+9 −4

Original line number	Diff line number	Diff line
		@@ -49,17 +49,22 @@ static void __udelay_disabled(unsigned long usecs)
		static void __udelay_enabled(unsigned long usecs)
		{
		unsigned long mask;
		u64 end, time;
		u64 clock_saved;
		u64 end;

		mask = psw_kernel_bits \| PSW_MASK_WAIT \| PSW_MASK_EXT \| PSW_MASK_IO;
		end = get_clock() + ((u64) usecs << 12);
		do {
		time = end < S390_lowcore.clock_comparator ?
		end : S390_lowcore.clock_comparator;
		set_clock_comparator(time);
		clock_saved = 0;
		if (end < S390_lowcore.clock_comparator) {
		clock_saved = local_tick_disable();
		set_clock_comparator(end);
		}
		trace_hardirqs_on();
		__load_psw_mask(mask);
		local_irq_disable();
		if (clock_saved)
		local_tick_enable(clock_saved);
		} while (get_clock() < end);
		set_clock_comparator(S390_lowcore.clock_comparator);
		}

Admin message