Commit 78ce08df authored by Taeung Song's avatar Taeung Song Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Rename 'colors.code' to 'colors.jump_arrows' 



USe 'jump_arrows' config name instead of 'code' on 'colors' section.
'colors.code' config is only for jump arrows on assembly code listings
i.e.

    │     ┌──jmp    1333
    │     │  xchg   %ax,%ax
    │     │  mov    %r15,%r10
    │     └─→cmp    %r15,%r14

But this config name seems unfit.

 'jump_arrows' is more descriptive than 'code'.

Signed-off-by: default avatarTaeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1452240971-25418-1-git-send-email-treeze.taeung@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 3379e0c3

tools/perf/Documentation/perf-config.txt

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this: 
		medium = green, default

		normal = lightgray, default

		selected = white, lightgray

		code = blue, default

		jump_arrows = blue, default

		addr = magenta, default

		root = white, blue

tools/perf/Documentation/perfconfig.example

+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
	medium = green, lightgray

	normal = black, lightgray

	selected = lightgray, magenta

	code = blue, lightgray

	jump_arrows = blue, lightgray

	addr = magenta, lightgray



[tui]

tools/perf/ui/browser.c

+2 −2
Original line number Diff line number Diff line
@@ -531,8 +531,8 @@ static struct ui_browser_colorset { 
		.bg	  = "yellow",

	},

	{

		.colorset = HE_COLORSET_CODE,

		.name	  = "code",

		.colorset = HE_COLORSET_JUMP_ARROWS,

		.name	  = "jump_arrows",

		.fg	  = "blue",

		.bg	  = "default",

	},

tools/perf/ui/browser.h

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ 
#define HE_COLORSET_MEDIUM	51

#define HE_COLORSET_NORMAL	52

#define HE_COLORSET_SELECTED	53

#define HE_COLORSET_CODE	54

#define HE_COLORSET_JUMP_ARROWS	54

#define HE_COLORSET_ADDR	55

#define HE_COLORSET_ROOT	56

tools/perf/ui/browsers/annotate.c

+1 −1
Original line number Diff line number Diff line
@@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) 
		to = (u64)btarget->idx;

	}



	ui_browser__set_color(browser, HE_COLORSET_CODE);

	ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS);

	__ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width,

				 from, to);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE