Commit 78c3e5e6 authored Mar 13, 2020 by Arun Easi Committed by Martin K. Petersen Mar 17, 2020

scsi: qla2xxx: Fix I/Os being passed down when FC device is being deleted

I/Os could be passed down while the device FC SCSI device is being deleted.
This would result in unnecessary delay of I/O and driver messages (when
extended logging is set).

[mkp: fixed commit hash and added SoB for Nilesh]

Link: https://lore.kernel.org/r/20200313085001.3781-1-njavali@marvell.com


Fixes: 3c75ad1d ("scsi: qla2xxx: Remove defer flag to indicate immeadiate port loss") # v5.6-rc1+
Tested-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 394b6171

drivers/scsi/qla2xxx/qla_os.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -864,7 +864,7 @@ qla2xxx_queuecommand(struct Scsi_Host host, struct scsi_cmnd cmd)
		goto qc24_fail_command;
		}

		if (atomic_read(&fcport->state) != FCS_ONLINE) {
		if (atomic_read(&fcport->state) != FCS_ONLINE \|\| fcport->deleted) {
		if (atomic_read(&fcport->state) == FCS_DEVICE_DEAD \|\|
		atomic_read(&base_vha->loop_state) == LOOP_DEAD) {
		ql_dbg(ql_dbg_io, vha, 0x3005,
		@@ -946,7 +946,7 @@ qla2xxx_mqueuecommand(struct Scsi_Host host, struct scsi_cmnd cmd,
		goto qc24_fail_command;
		}

		if (atomic_read(&fcport->state) != FCS_ONLINE) {
		if (atomic_read(&fcport->state) != FCS_ONLINE \|\| fcport->deleted) {
		if (atomic_read(&fcport->state) == FCS_DEVICE_DEAD \|\|
		atomic_read(&base_vha->loop_state) == LOOP_DEAD) {
		ql_dbg(ql_dbg_io, vha, 0x3077,

Admin message