Commit 78b99577 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Linus Walleij
Browse files

pinctrl: remove unused pin_is_valid() 



This function was used by pin_request() to pointlessly double-check
the pin validity, and it was the only user ever.

Since commit d2f6a1c6 ("pinctrl: remove double pin validity
check."), no one has ever used it.

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 6cadafb3

drivers/pinctrl/core.c

+0 −23
Original line number Original line Diff line number Diff line
@@ -178,29 +178,6 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin) 
	return desc->name;

	return desc->name;

}

}





/**

 * pin_is_valid() - check if pin exists on controller

 * @pctldev: the pin control device to check the pin on

 * @pin: pin to check, use the local pin controller index number

 *

 * This tells us whether a certain pin exist on a certain pin controller or

 * not. Pin lists may be sparse, so some pins may not exist.

 */

bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)

{

	struct pin_desc *pindesc;



	if (pin < 0)

		return false;



	mutex_lock(&pctldev->mutex);

	pindesc = pin_desc_get(pctldev, pin);

	mutex_unlock(&pctldev->mutex);



	return pindesc != NULL;

}

EXPORT_SYMBOL_GPL(pin_is_valid);



/* Deletes a range of pin descriptors */

/* Deletes a range of pin descriptors */

static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev,

static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev,

				  const struct pinctrl_pin_desc *pins,

				  const struct pinctrl_pin_desc *pins,

include/linux/pinctrl/pinctrl.h

+0 −10
Original line number Original line Diff line number Diff line
@@ -172,7 +172,6 @@ extern struct pinctrl_dev *devm_pinctrl_register(struct device *dev, 
extern void devm_pinctrl_unregister(struct device *dev,

extern void devm_pinctrl_unregister(struct device *dev,

				struct pinctrl_dev *pctldev);

				struct pinctrl_dev *pctldev);





extern bool pin_is_valid(struct pinctrl_dev *pctldev, int pin);

extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,

extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,

				struct pinctrl_gpio_range *range);

				struct pinctrl_gpio_range *range);

extern void pinctrl_add_gpio_ranges(struct pinctrl_dev *pctldev,

extern void pinctrl_add_gpio_ranges(struct pinctrl_dev *pctldev,
@@ -203,15 +202,6 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np) 
extern const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev);

extern const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev);

extern const char *pinctrl_dev_get_devname(struct pinctrl_dev *pctldev);

extern const char *pinctrl_dev_get_devname(struct pinctrl_dev *pctldev);

extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);

extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);

#else



struct pinctrl_dev;



/* Sufficiently stupid default functions when pinctrl is not in use */

static inline bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)

{

	return pin >= 0;

}





#endif /* !CONFIG_PINCTRL */

#endif /* !CONFIG_PINCTRL */

CRA Git | Maintained and supported by SUSTech CRA and CCSE