Commit 78b6d91e authored by Ira Weiny's avatar Ira Weiny Committed by Linus Torvalds
Browse files

arch/kmap_atomic: consolidate duplicate code 



Every arch has the same code to ensure atomic operations and a check for
!HIGHMEM page.

Remove the duplicate code by defining a core kmap_atomic() which only
calls the arch specific kmap_atomic_high() when the page is high memory.

[akpm@linux-foundation.org: coding style fixes]
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20200507150004.1423069-7-ira.weiny@intel.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ee9bc5fd

arch/arc/include/asm/highmem.h

+0 −1
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ 


#include <asm/cacheflush.h>



extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);



extern void kmap_init(void);

arch/arc/mm/highmem.c

+2 −7
Original line number Diff line number Diff line
@@ -49,16 +49,11 @@ 
extern pte_t * pkmap_page_table;

static pte_t * fixmap_page_table;



void *kmap_atomic(struct page *page)

void *kmap_atomic_high(struct page *page)

{

	int idx, cpu_idx;

	unsigned long vaddr;



	preempt_disable();

	pagefault_disable();

	if (!PageHighMem(page))

		return page_address(page);



	cpu_idx = kmap_atomic_idx_push();

	idx = cpu_idx + KM_TYPE_NR * smp_processor_id();

	vaddr = FIXMAP_ADDR(idx);
@@ -68,7 +63,7 @@ void *kmap_atomic(struct page *page) 


	return (void *)vaddr;

}

EXPORT_SYMBOL(kmap_atomic);

EXPORT_SYMBOL(kmap_atomic_high);



void __kunmap_atomic(void *kv)

{

arch/arm/include/asm/highmem.h

+0 −1
Original line number Diff line number Diff line
@@ -60,7 +60,6 @@ static inline void *kmap_high_get(struct page *page) 
 * when CONFIG_HIGHMEM is not set.

 */

#ifdef CONFIG_HIGHMEM

extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);

extern void *kmap_atomic_pfn(unsigned long pfn);

#endif

arch/arm/mm/highmem.c

+2 −7
Original line number Diff line number Diff line
@@ -31,18 +31,13 @@ static inline pte_t get_fixmap_pte(unsigned long vaddr) 
	return *ptep;

}



void *kmap_atomic(struct page *page)

void *kmap_atomic_high(struct page *page)

{

	unsigned int idx;

	unsigned long vaddr;

	void *kmap;

	int type;



	preempt_disable();

	pagefault_disable();

	if (!PageHighMem(page))

		return page_address(page);



#ifdef CONFIG_DEBUG_HIGHMEM

	/*

	 * There is no cache coherency issue when non VIVT, so force the
@@ -76,7 +71,7 @@ void *kmap_atomic(struct page *page) 


	return (void *)vaddr;

}

EXPORT_SYMBOL(kmap_atomic);

EXPORT_SYMBOL(kmap_atomic_high);



void __kunmap_atomic(void *kvaddr)

{

arch/csky/include/asm/highmem.h

+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@ extern pte_t *pkmap_page_table; 


#define ARCH_HAS_KMAP_FLUSH_TLB

extern void kmap_flush_tlb(unsigned long addr);

extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);

extern void *kmap_atomic_pfn(unsigned long pfn);

extern struct page *kmap_atomic_to_page(void *ptr);

CRA Git | Maintained and supported by SUSTech CRA and CCSE