Commit 78b495c3 authored Sep 03, 2012 by Artem Bityutskiy

UBI: fix a horrible memory deallocation bug



UBI was mistakingly using 'kfree()' instead of 'kmem_cache_free()' when
freeing "attach eraseblock" structures in vtbl.c. Thankfully, this happened
only when we were doing auto-format, so many systems were unaffected. However,
there are still many users affected.

It is strange, but the system did not crash and nothing bad happened when
the SLUB memory allocator was used. However, in case of SLOB we observed an
crash right away.

This problem was introduced in 2.6.39 by commit
"6c1e875c UBI: add slab cache for ubi_scan_leb objects"

A note for stable trees:
  Because variable were renamed, this won't cleanly apply to older kernels.
  Changing names like this should help:
	1. ai -> si
	2. aeb_slab_cache -> seb_slab_cache
	3. new_aeb -> new_seb

Reported-by: Richard Genoud <richard.genoud@gmail.com>
Tested-by: Richard Genoud <richard.genoud@gmail.com>
Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: stable@vger.kernel.org [v2.6.39+]
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

parent 4cbe5a55

drivers/mtd/ubi/vtbl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -340,7 +340,7 @@ retry:
		* of this LEB as it will be deleted and freed in 'ubi_add_to_av()'.
		*/
		err = ubi_add_to_av(ubi, ai, new_aeb->pnum, new_aeb->ec, vid_hdr, 0);
		kfree(new_aeb);
		kmem_cache_free(ai->aeb_slab_cache, new_aeb);
		ubi_free_vid_hdr(ubi, vid_hdr);
		return err;

		@@ -353,7 +353,7 @@ write_error:
		list_add(&new_aeb->u.list, &ai->erase);
		goto retry;
		}
		kfree(new_aeb);
		kmem_cache_free(ai->aeb_slab_cache, new_aeb);
		out_free:
		ubi_free_vid_hdr(ubi, vid_hdr);
		return err;

Admin message