mrf24j40: remove spi settings overwrite (78aedb6b) · Commits · 戴 / test

This patch removes spi settings while mrf24j40 probing. These settings cannot be overwrite while device probing where spi controller should be already configured. These settings need to be setup by device tree or platform data. Reviewed-by:

Stefan Schmidt <stefan@osg.samsung.com> Signed-off-by:

Alexander Aring <alex.aring@gmail.com> Signed-off-by:

Marcel Holtmann <marcel@holtmann.org>

drivers/net/ieee802154/mrf24j40.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -746,9 +746,11 @@ static int mrf24j40_probe(struct spi_device *spi)
		if (!devrec->buf)
		goto err_register_device;

		spi->mode = SPI_MODE_0; /* TODO: Is this appropriate for right here? */
		if (spi->max_speed_hz > MAX_SPI_SPEED_HZ)
		spi->max_speed_hz = MAX_SPI_SPEED_HZ;
		if (spi->max_speed_hz > MAX_SPI_SPEED_HZ) {
		dev_warn(&spi->dev, "spi clock above possible maximum: %d",
		MAX_SPI_SPEED_HZ);
		return -EINVAL;
		}

		mutex_init(&devrec->buffer_mutex);
		init_completion(&devrec->tx_complete);

Admin message