drm/i915: Remove unnecessary () used with WARN() (78ace48c) · Commits · 戴 / test

In Linux, macros are usually well done and protect their arguments properly, even avoiding multiple evaluations of the parameters. Extra () are really not needed. Cc: Suketu Shah <suketu.j.shah@intel.com> Signed-off-by:

Damien Lespiau <damien.lespiau@intel.com> Signed-off-by:

Daniel Vetter <daniel.vetter@ffwll.ch>

drivers/gpu/drm/i915/intel_csr.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -459,7 +459,8 @@ void intel_csr_ucode_fini(struct drm_device *dev)

		void assert_csr_loaded(struct drm_i915_private *dev_priv)
		{
		WARN((intel_csr_load_status_get(dev_priv) != FW_LOADED), "CSR is not loaded.\n");
		WARN(intel_csr_load_status_get(dev_priv) != FW_LOADED,
		"CSR is not loaded.\n");
		WARN(!I915_READ(CSR_PROGRAM_BASE),
		"CSR program storage start is NULL\n");
		WARN(!I915_READ(CSR_SSP_BASE), "CSR SSP Base Not fine\n");

Admin message