Commit 78a8d7c8 authored Jul 19, 2010 by Jeff Layton Committed by J. Bruce Fields Jul 23, 2010

nfsd: fix error handling when starting nfsd with rpcbind down



The refcounting for nfsd is a little goofy. What happens is that we
create the nfsd RPC service, attach sockets to it but don't actually
start the threads until someone writes to the "threads" procfile. To do
this, __write_ports_addfd will create the nfsd service and then will
decrement the refcount when exiting but won't actually destroy the
service.

This is fine when there aren't errors, but when there are this can
cause later attempts to start nfsd to fail. nfsd_serv will be set,
and that causes __write_versions to return EBUSY.

Fix this by calling svc_destroy on nfsd_serv when this function is
going to return error.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 4ad9a344

fs/nfsd/nfsctl.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -950,14 +950,18 @@ static ssize_t __write_ports_addfd(char *buf)
		return err;

		err = lockd_up();
		if (err != 0)
		goto out;
		if (err != 0) {
		svc_destroy(nfsd_serv);
		return err;
		}

		err = svc_addsock(nfsd_serv, fd, buf, SIMPLE_TRANSACTION_LIMIT);
		if (err < 0)
		if (err < 0) {
		lockd_down();
		svc_destroy(nfsd_serv);
		return err;
		}

		out:
		/* Decrease the count, but don't shut down the service */
		nfsd_serv->sv_nrthreads--;
		return err;

Admin message