Commit 78a32054 authored Sep 16, 2012 by Oleg Nesterov

uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC



uprobe_register() or uprobe_mmap() requires VM_READ | VM_EXEC, this
is not right. An apllication can do mprotect(PROT_EXEC) later and
execute this code.

Change valid_vma(is_register => true) to check VM_MAYEXEC instead.
No need to check VM_MAYREAD, it is always set.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

parent 75ed82ea

kernel/events/uprobes.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -106,8 +106,8 @@ static bool valid_vma(struct vm_area_struct *vma, bool is_register)
		if (!is_register)
		return true;

		if ((vma->vm_flags & (VM_HUGETLB\|VM_READ\|VM_WRITE\|VM_EXEC\|VM_SHARED))
		== (VM_READ\|VM_EXEC))
		if ((vma->vm_flags & (VM_HUGETLB \| VM_WRITE \| VM_MAYEXEC \| VM_SHARED))
		== VM_MAYEXEC)
		return true;

		return false;

Admin message