gpio: max77620: Don't set of_node (78934d88) · Commits · 戴 / test

The gpiochip_add_data() takes care of setting the of_node to the parent's device of_node, hence there is no need to do it manually in the driver's code. This patch corrects the parent's device pointer and removes the unnecessary setting of the of_node. Suggested-by:

Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:

Dmitry Osipenko <digetx@gmail.com> Reviewed-by:

Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by:

Laxman Dewangan <ldewangan@nvidia.com> Link: https://lore.kernel.org/r/20200709171203.12950-4-digetx@gmail.com Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-max77620.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -279,7 +279,7 @@ static int max77620_gpio_probe(struct platform_device *pdev)
		mgpio->dev = &pdev->dev;

		mgpio->gpio_chip.label = pdev->name;
		mgpio->gpio_chip.parent = &pdev->dev;
		mgpio->gpio_chip.parent = pdev->dev.parent;
		mgpio->gpio_chip.direction_input = max77620_gpio_dir_input;
		mgpio->gpio_chip.get = max77620_gpio_get;
		mgpio->gpio_chip.direction_output = max77620_gpio_dir_output;
		@@ -288,9 +288,6 @@ static int max77620_gpio_probe(struct platform_device *pdev)
		mgpio->gpio_chip.ngpio = MAX77620_GPIO_NR;
		mgpio->gpio_chip.can_sleep = 1;
		mgpio->gpio_chip.base = -1;
		#ifdef CONFIG_OF_GPIO
		mgpio->gpio_chip.of_node = pdev->dev.parent->of_node;
		#endif

		platform_set_drvdata(pdev, mgpio);

Admin message