Unverified Commit 78927aa4 authored Apr 20, 2019 by Linus Walleij Committed by Mark Brown Apr 25, 2019

regulator: core: Actually put the gpiod after use



I went to great lengths to hand over the management of the GPIO
descriptors to the regulator core, and some stray rebased
oneliner in the old patch must have been assuming the devices
were still doing devres management of it.

We handed the management over to the regulator core, so of
course the regulator core shall issue gpiod_put() when done.

Sorry for the descriptor leak.

Fixes: 541d052d ("regulator: core: Only support passing enable GPIO descriptors")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 06377301

drivers/regulator/core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2256,6 +2256,7 @@ static void regulator_ena_gpio_free(struct regulator_dev *rdev)
		if (pin->gpiod == rdev->ena_pin->gpiod) {
		if (pin->request_count <= 1) {
		pin->request_count = 0;
		gpiod_put(pin->gpiod);
		list_del(&pin->list);
		kfree(pin);
		rdev->ena_pin = NULL;

Admin message