Commit 788b041a authored Feb 13, 2020 by Alexander Fomichev Committed by Jon Mason Mar 13, 2020

ntb_hw_switchtec: Fix ntb_mw_clear_trans error if size == 0



ntb_mw_set_trans() should work as ntb_mw_clear_trans() when size == 0 and/or
addr == 0. But error in xlate_pos checking condition prevents this.
Fix the condition to make ntb_mw_clear_trans() working.

Fixes: 87d11e64 (NTB: switchtec_ntb: Add memory window support)
Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>

parent 2ef97a6c

drivers/ntb/hw/mscc/ntb_hw_switchtec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -285,7 +285,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx,
		if (widx >= switchtec_ntb_mw_count(ntb, pidx))
		return -EINVAL;

		if (xlate_pos < 12)
		if (size != 0 && xlate_pos < 12)
		return -EINVAL;

		if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) {

Admin message