Commit 7888da95 authored Jan 02, 2018 by Dan Carpenter Committed by David Howells Jan 02, 2018

afs: Potential uninitialized variable in afs_extract_data()



Smatch warns that:

    fs/afs/rxrpc.c:922 afs_extract_data()
    error: uninitialized symbol 'remote_abort'.

Smatch is right that "remote_abort" might be uninitialized when we pass
it to afs_set_call_complete().  I don't know if that function uses the
uninitialized variable.  Anyway, the comment for rxrpc_kernel_recv_data(),
says that "*_abort should also be initialised to 0." and this patch does
that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>

parent 98801506

fs/afs/rxrpc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -885,7 +885,7 @@ int afs_extract_data(struct afs_call call, void buf, size_t count,
		{
		struct afs_net *net = call->net;
		enum afs_call_state state;
		u32 remote_abort;
		u32 remote_abort = 0;
		int ret;

		_enter("{%s,%zu},,%zu,%d",

Admin message