Commit 787d3083 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Vinod Koul
Browse files

dmaengine: dmatest: move size checks earlier in function 



There's no need to allocate all that memory if these sizes are invalid
anyway.

Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent fbffb6b4

drivers/dma/dmatest.c

+13 −13
Original line number Diff line number Diff line
@@ -507,6 +507,19 @@ static int dmatest_func(void *data) 
	} else

		goto err_thread_type;



	/* Check if buffer count fits into map count variable (u8) */

	if ((src_cnt + dst_cnt) >= 255) {

		pr_err("too many buffers (%d of 255 supported)\n",

		       src_cnt + dst_cnt);

		goto err_thread_type;

	}



	if (1 << align > params->buf_size) {

		pr_err("%u-byte buffer too small for %d-byte alignment\n",

		       params->buf_size, 1 << align);

		goto err_thread_type;

	}



	thread->srcs = kcalloc(src_cnt + 1, sizeof(u8 *), GFP_KERNEL);

	if (!thread->srcs)

		goto err_srcs;
@@ -576,19 +589,6 @@ static int dmatest_func(void *data) 


		total_tests++;



		/* Check if buffer count fits into map count variable (u8) */

		if ((src_cnt + dst_cnt) >= 255) {

			pr_err("too many buffers (%d of 255 supported)\n",

			       src_cnt + dst_cnt);

			break;

		}



		if (1 << align > params->buf_size) {

			pr_err("%u-byte buffer too small for %d-byte alignment\n",

			       params->buf_size, 1 << align);

			break;

		}



		if (params->norandom)

			len = params->buf_size;

		else

CRA Git | Maintained and supported by SUSTech CRA and CCSE