drm: mxsfb: Use LCDC_CTRL register name explicitly (7865cd5a) · Commits · 戴 / test

The LCDC_CTRL register is located at address 0x0000. Some of the accesses to the register simply use the mxsfb->base address. Reference the LCDC_CTRL register explicitly instead to clarify the code. Signed-off-by:

Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:

Stefan Agner <stefan@agner.ch> Reviewed-by:

Emil Velikov <emil.l.velikov@gmail.com> Signed-off-by:

Stefan Agner <stefan@agner.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20200727020654.8231-8-laurent.pinchart@ideasonboard.com

drivers/gpu/drm/mxsfb/mxsfb_crtc.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -170,17 +170,17 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb)
		{
		int ret;

		ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST);
		ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST);
		if (ret)
		return ret;

		writel(MODULE_CLKGATE, mxsfb->base + MXS_CLR_ADDR);
		writel(MODULE_CLKGATE, mxsfb->base + LCDC_CTRL + MXS_CLR_ADDR);

		ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST);
		ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST);
		if (ret)
		return ret;

		return clear_poll_bit(mxsfb->base, MODULE_CLKGATE);
		return clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_CLKGATE);
		}

		static dma_addr_t mxsfb_get_fb_paddr(struct mxsfb_drm_private *mxsfb)

Admin message