Commit 78608ba0 authored Nov 10, 2007 by Chuck Lever Committed by David S. Miller Nov 10, 2007

[NET]: Fix skb_truesize_check() assertion



The intent of the assertion in skb_truesize_check() is to check
for skb->truesize being decremented too much by other code,
resulting in a wraparound below zero.

The type of the right side of the comparison causes the compiler to
promote the left side to an unsigned type, despite the presence of an
explicit type cast.  This defeats the check for negativity.

Ensure both sides of the comparison are a signed type to prevent the
implicit type conversion.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 39aaac11

include/linux/skbuff.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -387,7 +387,9 @@ extern void skb_truesize_bug(struct sk_buff *skb);

		static inline void skb_truesize_check(struct sk_buff *skb)
		{
		if (unlikely((int)skb->truesize < sizeof(struct sk_buff) + skb->len))
		int len = sizeof(struct sk_buff) + skb->len;

		if (unlikely((int)skb->truesize < len))
		skb_truesize_bug(skb);
		}

Admin message