Commit 784e0300 authored by Will Deacon's avatar Will Deacon Committed by Thomas Gleixner
Browse files

rseq: Avoid infinite recursion when delivering SIGSEGV 



When delivering a signal to a task that is using rseq, we call into
__rseq_handle_notify_resume() so that the registers pushed in the
sigframe are updated to reflect the state of the restartable sequence
(for example, ensuring that the signal returns to the abort handler if
necessary).

However, if the rseq management fails due to an unrecoverable fault when
accessing userspace or certain combinations of RSEQ_CS_* flags, then we
will attempt to deliver a SIGSEGV. This has the potential for infinite
recursion if the rseq code continuously fails on signal delivery.

Avoid this problem by using force_sigsegv() instead of force_sig(), which
is explicitly designed to reset the SEGV handler to SIG_DFL in the case
of a recursive fault. In doing so, remove rseq_signal_deliver() from the
internal rseq API and have an optional struct ksignal * parameter to
rseq_handle_notify_resume() instead.

Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: peterz@infradead.org
Cc: paulmck@linux.vnet.ibm.com
Cc: boqun.feng@gmail.com
Link: https://lkml.kernel.org/r/1529664307-983-1-git-send-email-will.deacon@arm.com
parent 9a789fcf

arch/arm/kernel/signal.c

+2 −2
Original line number Diff line number Diff line
@@ -544,7 +544,7 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs) 
	 * Increment event counter and perform fixup for the pre-signal

	 * frame.

	 */

	rseq_signal_deliver(regs);

	rseq_signal_deliver(ksig, regs);



	/*

	 * Set up the stack frame
@@ -666,7 +666,7 @@ do_work_pending(struct pt_regs *regs, unsigned int thread_flags, int syscall) 
			} else {

				clear_thread_flag(TIF_NOTIFY_RESUME);

				tracehook_notify_resume(regs);

				rseq_handle_notify_resume(regs);

				rseq_handle_notify_resume(NULL, regs);

			}

		}

		local_irq_disable();

arch/powerpc/kernel/signal.c

+2 −2
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ static void do_signal(struct task_struct *tsk) 
	/* Re-enable the breakpoints for the signal stack */

	thread_change_pc(tsk, tsk->thread.regs);



	rseq_signal_deliver(tsk->thread.regs);

	rseq_signal_deliver(&ksig, tsk->thread.regs);



	if (is32) {

        	if (ksig.ka.sa.sa_flags & SA_SIGINFO)
@@ -170,7 +170,7 @@ void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags) 
	if (thread_info_flags & _TIF_NOTIFY_RESUME) {

		clear_thread_flag(TIF_NOTIFY_RESUME);

		tracehook_notify_resume(regs);

		rseq_handle_notify_resume(regs);

		rseq_handle_notify_resume(NULL, regs);

	}



	user_enter();

arch/x86/entry/common.c

+1 −1
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ static void exit_to_usermode_loop(struct pt_regs *regs, u32 cached_flags) 
		if (cached_flags & _TIF_NOTIFY_RESUME) {

			clear_thread_flag(TIF_NOTIFY_RESUME);

			tracehook_notify_resume(regs);

			rseq_handle_notify_resume(regs);

			rseq_handle_notify_resume(NULL, regs);

		}



		if (cached_flags & _TIF_USER_RETURN_NOTIFY)

arch/x86/kernel/signal.c

+1 −1
Original line number Diff line number Diff line
@@ -692,7 +692,7 @@ setup_rt_frame(struct ksignal *ksig, struct pt_regs *regs) 
	 * Increment event counter and perform fixup for the pre-signal

	 * frame.

	 */

	rseq_signal_deliver(regs);

	rseq_signal_deliver(ksig, regs);



	/* Set up the stack frame */

	if (is_ia32_frame(ksig)) {

include/linux/sched.h

+11 −7
Original line number Diff line number Diff line
@@ -1799,20 +1799,22 @@ static inline void rseq_set_notify_resume(struct task_struct *t) 
		set_tsk_thread_flag(t, TIF_NOTIFY_RESUME);

}



void __rseq_handle_notify_resume(struct pt_regs *regs);

void __rseq_handle_notify_resume(struct ksignal *sig, struct pt_regs *regs);



static inline void rseq_handle_notify_resume(struct pt_regs *regs)

static inline void rseq_handle_notify_resume(struct ksignal *ksig,

					     struct pt_regs *regs)

{

	if (current->rseq)

		__rseq_handle_notify_resume(regs);

		__rseq_handle_notify_resume(ksig, regs);

}



static inline void rseq_signal_deliver(struct pt_regs *regs)

static inline void rseq_signal_deliver(struct ksignal *ksig,

				       struct pt_regs *regs)

{

	preempt_disable();

	__set_bit(RSEQ_EVENT_SIGNAL_BIT, &current->rseq_event_mask);

	preempt_enable();

	rseq_handle_notify_resume(regs);

	rseq_handle_notify_resume(ksig, regs);

}



/* rseq_preempt() requires preemption to be disabled. */
@@ -1861,10 +1863,12 @@ static inline void rseq_execve(struct task_struct *t) 
static inline void rseq_set_notify_resume(struct task_struct *t)

{

}

static inline void rseq_handle_notify_resume(struct pt_regs *regs)

static inline void rseq_handle_notify_resume(struct ksignal *ksig,

					     struct pt_regs *regs)

{

}

static inline void rseq_signal_deliver(struct pt_regs *regs)

static inline void rseq_signal_deliver(struct ksignal *ksig,

				       struct pt_regs *regs)

{

}

static inline void rseq_preempt(struct task_struct *t)

CRA Git | Maintained and supported by SUSTech CRA and CCSE