Commit 7841f40a authored by Jin Yao's avatar Jin Yao Committed by Arnaldo Carvalho de Melo
Browse files

perf hist: Count the total cycles of all samples 



We can get the per sample cycles by hist__account_cycles(). It's also
useful to know the total cycles of all samples in order to get the
cycles coverage for a single program block in further. For example:

  coverage = per block sampled cycles / total sampled cycles

This patch creates a new argument 'total_cycles' in hist__account_cycles(),
which will be added with the cycles of each sample.

Signed-off-by: default avatarJin Yao <yao.jin@linux.intel.com>
Reviewed-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20191107074719.26139-4-yao.jin@linux.intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 60414418

tools/perf/builtin-annotate.c

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ static int process_branch_callback(struct evsel *evsel, 
	if (a.map != NULL)

		a.map->dso->hit = 1;



	hist__account_cycles(sample->branch_stack, al, sample, false);

	hist__account_cycles(sample->branch_stack, al, sample, false, NULL);



	ret = hist_entry_iter__add(&iter, &a, PERF_MAX_STACK_DEPTH, ann);

	return ret;

tools/perf/builtin-diff.c

+2 −1
Original line number Diff line number Diff line
@@ -426,7 +426,8 @@ static int diff__process_sample_event(struct perf_tool *tool, 
			goto out_put;

		}



		hist__account_cycles(sample->branch_stack, &al, sample, false);

		hist__account_cycles(sample->branch_stack, &al, sample, false,

				     NULL);

	}



	/*

tools/perf/builtin-report.c

+1 −1
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static int process_sample_event(struct perf_tool *tool, 


	if (ui__has_annotation() || rep->symbol_ipc) {

		hist__account_cycles(sample->branch_stack, &al, sample,

				     rep->nonany_branch_mode);

				     rep->nonany_branch_mode, NULL);

	}



	ret = hist_entry_iter__add(&iter, &al, rep->max_stack, rep);

tools/perf/builtin-top.c

+2 −1
Original line number Diff line number Diff line
@@ -725,7 +725,8 @@ static int hist_iter__top_callback(struct hist_entry_iter *iter, 
		perf_top__record_precise_ip(top, he, iter->sample, evsel, al->addr);



	hist__account_cycles(iter->sample->branch_stack, al, iter->sample,

		     !(top->record_opts.branch_stack & PERF_SAMPLE_BRANCH_ANY));

		     !(top->record_opts.branch_stack & PERF_SAMPLE_BRANCH_ANY),

		     NULL);

	return 0;

}

tools/perf/util/hist.c

+5 −1
Original line number Diff line number Diff line
@@ -2572,7 +2572,8 @@ int hists__unlink(struct hists *hists) 
}



void hist__account_cycles(struct branch_stack *bs, struct addr_location *al,

			  struct perf_sample *sample, bool nonany_branch_mode)

			  struct perf_sample *sample, bool nonany_branch_mode,

			  u64 *total_cycles)

{

	struct branch_info *bi;
@@ -2599,6 +2600,9 @@ void hist__account_cycles(struct branch_stack *bs, struct addr_location *al, 
					nonany_branch_mode ? NULL : prev,

					bi[i].flags.cycles);

				prev = &bi[i].to;



				if (total_cycles)

					*total_cycles += bi[i].flags.cycles;

			}

			free(bi);

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE